[Differential] [Commented On] D4220: Add a basic SNI for keyboard layout

[Martin Gräßlin]

graesslin added inline comments.

INLINE COMMENTS

> davidedmundson wrote in keyboard_layout.cpp:142
> You only want this in ::reconfigure() before resetLayout and not here.
> 
> You're calling this method from reconfigure and in processKeymapChange, from keyboard_input - that won't affect whether you're showing or hiding it.

> that won't affect whether you're showing or hiding it.

Yes it does. processKeymapChange is called when a parent Wayland server informs this nested Wayland server about a new keymap. This means we have a new number of keyboard layouts and that can affect whether the notifier is shown or not.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D4220

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland
Cc: davidedmundson, luebking, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, eliasp, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170125/7ffd4919/attachment.html>