[Differential] [Commented On] D4220: Add a basic SNI for keyboard layout

[David Edmundson]

davidedmundson added a comment.


  One comment, but otherwise ship it.
  
  That contextMenu thing will come back to haunt us in the future, but hopefully SNI will be fixed by then.

INLINE COMMENTS

> keyboard_layout.cpp:142
>      m_layout = m_xkb->currentLayout();
> +    initNotifierItem();
> +    updateNotifier();

You only want this in ::reconfigure() before resetLayout and not here.

You're calling this method from reconfigure and in processKeymapChange, from keyboard_input - that won't affect whether you're showing or hiding it.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D4220

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland
Cc: davidedmundson, luebking, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, eliasp, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170124/f0b86c3b/attachment.html>