[Differential] [Commented On] D4193: KDEPlatformFileDialog: Fix initial directory selection for remote files

[Alex Richardson]

arichardson added inline comments.

INLINE COMMENTS

> graesslin wrote in kdeplatformfiledialoghelper.cpp:365-370
> Shouldn't that be a runtime check?

Yes it should be but what is the easy way to do that? Do I have to parse the result of qVersion()? CMakeLists.txt says the minimum version is 5.5 so I can't use QVersionNumber?

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D4193

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: arichardson, #plasma
Cc: graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170123/73b48822/attachment.html>