[Differential] [Changed Subscribers] D4193: KDEPlatformFileDialog: Fix initial directory selection for remote files

Martin Gräßlin noreply at phabricator.kde.org
Thu Jan 19 06:22:59 UTC 2017


graesslin added inline comments.

INLINE COMMENTS

> kdeplatformfiledialoghelper.cpp:365-370
> +#if QT_VERSION < QT_VERSION_CHECK(5, 7, 1)
> +    // Qt 5 at least <= 5.7.1 does not derive the directory from the passed url
>      // and set the initialDirectory option accordingly, also not for known schemes
>      // like file://, so we have to do it ourselves
>      options()->setInitialDirectory(m_dialog->directory());
> +#endif

Shouldn't that be a runtime check?

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D4193

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: arichardson, #plasma
Cc: graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170119/cf6b91ec/attachment.html>


More information about the Plasma-devel mailing list