Review Request 129835: [IconDialog] Set proper icons group
Anthony Fieroni
bvbfan at abv.bg
Thu Jan 19 06:04:28 UTC 2017
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129835/#review102090
-----------------------------------------------------------
Ping
- Anthony Fieroni
On Ян. 15, 2017, 12:27 след обяд, Anthony Fieroni wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129835/
> -----------------------------------------------------------
>
> (Updated Ян. 15, 2017, 12:27 след обяд)
>
>
> Review request for Plasma, Christoph Feck and Marco Martin.
>
>
> Repository: kdeclarative
>
>
> Description
> -------
>
> Follow the comment in IconThemes: https://api.kde.org/frameworks/kiconthemes/html/kicondialog_8cpp_source.html#l00500
> iconSize == 0 && group == KIconLoader::NoGroup
>
>
> Diffs
> -----
>
> src/qmlcontrols/kquickcontrolsaddons/icondialog.cpp be54174
>
> Diff: https://git.reviewboard.kde.org/r/129835/diff/
>
>
> Testing
> -------
>
> Change group to Desktop, explicit size will override it.
>
>
> Thanks,
>
> Anthony Fieroni
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170119/d06a8834/attachment-0001.html>
More information about the Plasma-devel
mailing list