Review Request 129835: [IconDialog] Set proper icons group

Anthony Fieroni bvbfan at abv.bg
Sun Jan 15 10:27:51 UTC 2017


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129835/
-----------------------------------------------------------

Review request for Plasma, Christoph Feck and Marco Martin.


Repository: kdeclarative


Description
-------

Follow the comment in IconThemes: https://api.kde.org/frameworks/kiconthemes/html/kicondialog_8cpp_source.html#l00500
iconSize == 0 && group == KIconLoader::NoGroup


Diffs
-----

  src/qmlcontrols/kquickcontrolsaddons/icondialog.cpp be54174 

Diff: https://git.reviewboard.kde.org/r/129835/diff/


Testing
-------

Change group to Desktop, explicit size will override it.


Thanks,

Anthony Fieroni

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170115/d9be982f/attachment.html>


More information about the Plasma-devel mailing list