Review Request 129838: fix no-display of CPU bars per core (and fix some warnings)

[Martin Koller]

> On Jan. 15, 2017, 3:29 p.m., David Edmundson wrote:
> > applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml, line 150
> > <https://git.reviewboard.kde.org/r/129838/diff/1/?file=489180#file489180line150>
> >
> >     I think we want:
> >     
> >     connectedSources: sources()
> >     
> >     
> >     otherwise if cores doesn't change we don't add all the other important sources.
> >     
> >     Given libksysguard has a tonne of backends, and the main linux one has this guarded in _SC_NPROCESSORS_ONLN this seems it could happen.

No, what you suggest is what I tried first, but that gives a "property loop" warning.
I asked on KDE-devel ML how to solve this and Kevin Krammer suggested to solve it similar to this.

AFAI understood, the values are polled, so there is no need that anything changes.


> On Jan. 15, 2017, 3:29 p.m., David Edmundson wrote:
> > applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml, line 258
> > <https://git.reviewboard.kde.org/r/129838/diff/1/?file=489180#file489180line258>
> >
> >     this doesn't match anything in the commit description.

This is the "and fix some warnings" part of the summary.
There were warnings like "can not use .value from undefined" or similar


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129838/#review102043
-----------------------------------------------------------


On Jan. 15, 2017, 2:36 p.m., Martin Koller wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129838/
> -----------------------------------------------------------
> 
> (Updated Jan. 15, 2017, 2:36 p.m.)
> 
> 
> Review request for Plasma and Kåre Särs.
> 
> 
> Bugs: 373776
>     http://bugs.kde.org/show_bug.cgi?id=373776
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> -------
> 
> See bug #373776
> The CPU bars do not show a value when using separate bars per CPU, and the tooltip never
> shows a value per CPU, since the data sources per CPU are not subscribed.
> 
> AFAICT this could never have worked.
> 
> 
> Diffs
> -----
> 
>   applets/systemloadviewer/package/contents/ui/CompactBarMonitor.qml 32d98dd 
>   applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml 5a0bc06 
> 
> Diff: https://git.reviewboard.kde.org/r/129838/diff/
> 
> 
> Testing
> -------
> 
> yes
> 
> 
> Thanks,
> 
> Martin Koller
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170115/243f3d6c/attachment.html>