Review Request 129838: fix no-display of CPU bars per core (and fix some warnings)

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129838/#review102043
-----------------------------------------------------------



seems mostly fine.


applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml (line 150)
<https://git.reviewboard.kde.org/r/129838/#comment68227>

    I think we want:
    
    connectedSources: sources()
    
    otherwise if cores doesn't change we don't add all the other important sources.
    
    Given libksysguard has a tonne of backends, and the main linux one has this guarded in _SC_NPROCESSORS_ONLN this seems it could happen.



applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml (line 258)
<https://git.reviewboard.kde.org/r/129838/#comment68226>

    this doesn't match anything in the commit description.


- David Edmundson


On Jan. 15, 2017, 2:36 p.m., Martin Koller wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129838/
> -----------------------------------------------------------
> 
> (Updated Jan. 15, 2017, 2:36 p.m.)
> 
> 
> Review request for Plasma and Kåre Särs.
> 
> 
> Bugs: 373776
>     http://bugs.kde.org/show_bug.cgi?id=373776
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> -------
> 
> See bug #373776
> The CPU bars do not show a value when using separate bars per CPU, and the tooltip never
> shows a value per CPU, since the data sources per CPU are not subscribed.
> 
> AFAICT this could never have worked.
> 
> 
> Diffs
> -----
> 
>   applets/systemloadviewer/package/contents/ui/CompactBarMonitor.qml 32d98dd 
>   applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml 5a0bc06 
> 
> Diff: https://git.reviewboard.kde.org/r/129838/diff/
> 
> 
> Testing
> -------
> 
> yes
> 
> 
> Thanks,
> 
> Martin Koller
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170115/6d0105f6/attachment-0001.html>