[Differential] [Commented On] D4001: [Image Wallpaper] Simplify width/height management

[davidedmundson (David Edmundson)]

davidedmundson added a comment.


  Cool, proper event compression, I'm a fan
  Two comments, then ship it.

INLINE COMMENTS

> image.cpp:235
>              m_wallpaperPackage.removeDefinition("preferred");
> +            emit targetSizeChanged();
>          }

I think this needs moving out of this block that says
if (m_mode == SingleImage)

Slideshow will still uses this binding.

> config.qml:50
>          id: imageWallpaper
> -        width: wallpaper.configuration.width
> -        height: wallpaper.configuration.height
> +        targetSize: Qt.size(Screen.width, Screen.height)
>          onSlidePathsChanged: cfg_SlidePaths = slidePaths

we can be improve that I think

configview exports the containment's graphic item as an attached property.

Qt.size(plasmoid.width, plasmoid.height)

This means PMC/Plasmoidviewer will still work correclty.

(tested just now)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D4001

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, andreaska, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170107/0b4db92f/attachment-0001.html>