Review Request 129783: [kio-extras] Make activities kioslave optional, KF5Html not required

[Andreas Sturmlechner]

> On Jan. 7, 2017, 4:48 a.m., Anthony Fieroni wrote:
> > CMakeLists.txt, line 168
> > <https://git.reviewboard.kde.org/r/129783/diff/1/?file=488757#file488757line168>
> >
> >     You still need find_package(KF5KHtml QUIET)

In the line above, but QUIET is indeed prettier, thanks.


- Andreas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129783/#review101846
-----------------------------------------------------------


On Jan. 7, 2017, 12:38 p.m., Andreas Sturmlechner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129783/
> -----------------------------------------------------------
> 
> (Updated Jan. 7, 2017, 12:38 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kio-extras
> 
> 
> Description
> -------
> 
> 2 commits:
> 
> - Make activities kioslave optional: Not everyone builds this for a Plasma desktop, Qt5Sql is already only searched for in that subdirectory, so this gives some nice modularity.
> - Make KF5Html dependency optional: only used by man
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt ba41101bb0cb247e55ded79224cd6bbbeb3f6b20 
> 
> Diff: https://git.reviewboard.kde.org/r/129783/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andreas Sturmlechner
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170107/91212427/attachment.html>