Review Request 129783: [kio-extras] Make activities kioslave optional, KF5Html not required

Anthony Fieroni bvbfan at abv.bg
Sat Jan 7 04:48:53 UTC 2017


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129783/#review101846
-----------------------------------------------------------




CMakeLists.txt (line 166)
<https://git.reviewboard.kde.org/r/129783/#comment68142>

    You still need find_package(KF5KHtml QUIET)


- Anthony Fieroni


On Ян. 7, 2017, 1:19 преди обяд, Andreas Sturmlechner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129783/
> -----------------------------------------------------------
> 
> (Updated Ян. 7, 2017, 1:19 преди обяд)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kio-extras
> 
> 
> Description
> -------
> 
> 2 commits:
> 
> - Make activities kioslave optional: Not everyone builds this for a Plasma desktop, Qt5Sql is already only searched for in that subdirectory, so this gives some nice modularity.
> - Make KF5Html dependency optional: only used by man
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt ba41101bb0cb247e55ded79224cd6bbbeb3f6b20 
> 
> Diff: https://git.reviewboard.kde.org/r/129783/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andreas Sturmlechner
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170107/8854f5a7/attachment-0001.html>


More information about the Plasma-devel mailing list