[Differential] [Commented On] D3950: Try to fix "Pinned Chrome disappears when all Chrome windows are closed"

[hein (Eike Hein)]

hein added a comment.


  For some reason Phab didn't update the summary even though I rewrote the commit message. Here's the new text:
  
    Fix "Pinned Chrome disappears when all Chrome windows are closed"
    
    Summary:
    It turns out that Chrome under certain conditions will change its
    window metadata as it quits, causing a race we sometimes lose, failing
    to reveal the associated launcher because we can no longer match it
    to the window at window closing time. Instead we are now forced to                                                                                                                                                               
    re-check all launchers after the window is gone. As a speed optimi-                                                                                                                                                              
    zation we only consider top-level windows (and startups) as being in                                                                                                                                                             
    a group implies matching siblings.                                                                                                                                                                                               
                                                                                                                                                                                                                                     
    In addition this refactoring eliminates a use of Qt::QueuedConnection                                                                                                                                                            
    that allowed for an unpredictable event loop spin inbetween things.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3950

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, davidedmundson, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, andreaska, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170106/fd7087b2/attachment.html>