[Differential] [Commented On] D3089: Restore global menu support

[davidedmundson (David Edmundson)]

davidedmundson added a comment.


  For the KCM I needed
  
  diff --git a/kcmkwin/kwindecoration/declarative-plugin/buttonsmodel.cpp b/kcmkwin/kwindecoration/declarative-plugin/buttonsmodel.cpp
  index b2ac124ed..26d779015 100644
  
  - a/kcmkwin/kwindecoration/declarative-plugin/buttonsmodel.cpp
  
  +++ b/kcmkwin/kwindecoration/declarative-plugin/buttonsmodel.cpp
  @@ -38,6 +38,7 @@ ButtonsModel::ButtonsModel(const QVector< DecorationButtonType > &buttons, QObje
   ButtonsModel::ButtonsModel(QObject* parent)
  
    : ButtonsModel(QVector<DecorationButtonType>({
        DecorationButtonType::Menu,
  
  +        DecorationButtonType::ApplicationMenu,
  
    DecorationButtonType::OnAllDesktops,
    DecorationButtonType::Minimize,
    DecorationButtonType::Maximize,
  
  to allow me to add the menu in the decoration, is this deliberately not available?

INLINE COMMENTS

> previewclient.cpp:314
> +{
> +    return false;
> +}

why? We'd want to see how it looks in the preview?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D3089

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: davidedmundson, graesslin, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, andreaska, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170106/ed365cd2/attachment-0001.html>