[Differential] [Commented On] D3981: better clean up of duplicate containments

[davidedmundson (David Edmundson)]

davidedmundson added inline comments.

INLINE COMMENTS

> shellcorona.cpp:1909
>      for (Plasma::Containment *c : m_desktopContainments.value(activity)) {
> -        if (c->screen() == screenNum) {
> +        //using lastScreen() instead of screen() catches also containments of other activities that aren't current, so not assigned to a screen right now
> +        if (c->lastScreen() == screenNum) {

> catches also containments of other activities

No it doesn't - you're looping through m_desktopContainments.value(activity)     so only things of the same activity.
Either your comment is nonsense, or your code is, or both.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3981

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, andreaska, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170105/1089f4ea/attachment.html>