[Differential] [Changed Subscribers] D3738: [Task Manager] Tooltips redesign

[anthonyfieroni (Anthony Fieroni)]

anthonyfieroni added inline comments.

INLINE COMMENTS

> subdiff wrote in ToolTipDelegate.qml:199
> I wanted to use Headings with different levels. The problem is, that they always automatically create huge margins. Since we wanted to minimize the size of the tooltips as much as possible, I used instead relative sizes, which worked way better for me, because they give a more direct control over the look in the end.
> 
> They are not really magic numbers, are they? Read the 0.75 value for example as: the window title font size is 75% as large as the font size of the app name.
> 
> Of course on the other side you raise a valid point with the consistency. Though I've seen relative font sizes also elsewhere (digital clock).

Why we want to make tooltip smaller? Your patch will effect all screens with higher resolution than your i.e. will be smaller to read. Do not use magic number, get it  pro rata of screen resolution. You must apply your patch to FullHD or bigger to see the difference.

> ToolTipDelegate.qml:237
> +                    width: header.width
> +                    // similar to 0.5625 = 1 / (16:9) as most screens are
> +                    // round necessary, otherwise shadow mask for players has gap!

Again, do not make a bad decisions, use Screen width, height and pixel ratio for HiDPI.

  import QtQuick.Window 2.2
  property int maxWidth: Screen.width / Screen.devicePixelRatio
  property int maxHeight: Screen.height / Screen.devicePixelRatio

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3738

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: subdiff, #vdg, #plasma, hein
Cc: anthonyfieroni, hein, colomar, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170104/d0cf759b/attachment.html>