[Differential] [Commented On] D4751: Button and Context Menu to Mute, Set Default Sink/Source, Active Port

[Chris Holland]

Zren added inline comments.

INLINE COMMENTS

> subdiff wrote in ListItemBase.qml:283
> > Please move literal to right side
> 
> I like to read my inequalities from lower value to higher one. Easier to read the code this way. Besides style is there something else speaking against that? What @Zren said?
> 
> > ...as the latter could be read as "if this variable exists".
> 
> Please explain what you mean by this.

I prefer `if (Ports.length > 0)` since that's how you'd read it in English. You wouldn't ask "is 0 less than the number of ports".

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D4751

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: subdiff, #plasma, drosca, Zren
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170223/7d72c02b/attachment.html>