[Differential] [Requested Changes] D4703: move the view at the correct index at startup

David Edmundson noreply at phabricator.kde.org
Thu Feb 23 14:13:32 UTC 2017


davidedmundson requested changes to this revision.
davidedmundson added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kcm.cpp:102
> +    //this should be the only context property
> +    m_quickView->rootContext()->setContextProperty(QStringLiteral("kcm"), this);
>      updateColors();

We can't do this.

You've just restored the crash when hitting back.
See https://phabricator.kde.org/R108:70d2fb2378d636ef6d052da08417b27c99182fb0

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D4703

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, davidedmundson, #plasma
Cc: davidedmundson, plasma-devel, kwin, #kwin, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170223/1bf53243/attachment.html>


More information about the Plasma-devel mailing list