[Differential] [Commented On] D4703: move the view at the correct index at startup

Marco Martin noreply at phabricator.kde.org
Tue Feb 21 15:33:27 UTC 2017


mart added inline comments.

INLINE COMMENTS

> davidedmundson wrote in kcm.cpp:320
> We're doing the exact same logic here. Duplicating it without deleting this is definitely wrong.
> 
> It looks like this should work as we've loaded the model and the model is populated at startup.
> However if it's not, just add a new int property on the listView.
> 
> Or at an absolute minimum delete this.

can be safely deleted.
it was working because was selecting the same index, makigng this effectively a noop

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D4703

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, davidedmundson, #plasma
Cc: davidedmundson, plasma-devel, kwin, #kwin, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170221/49bab473/attachment.html>


More information about the Plasma-devel mailing list