[Differential] [Commented On] D4736: Port: Expose port availability to QML

[David Rosca]

drosca added inline comments.

INLINE COMMENTS

> subdiff wrote in port.cpp:39
> Better put the definition of this getter in the header.

I prefer function definitions always in cpp file.

> subdiff wrote in port.h:66
> Better put the definition of this long method in the cpp file.

This is templated function, so that's why the definition is in header.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D4736

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma
Cc: subdiff, broulik, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170223/3af97453/attachment.html>