[Differential] [Changed Subscribers] D4736: Port: Expose port availability to QML

Roman Gilg noreply at phabricator.kde.org
Thu Feb 23 11:05:21 UTC 2017


subdiff added inline comments.

INLINE COMMENTS

> port.cpp:39
> +    return m_availability;
>  }
>  

Better put the definition of this getter in the header.

> port.h:66
>          }
>      }
>  

Better put the definition of this long method in the cpp file.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D4736

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma
Cc: subdiff, broulik, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170223/845acb93/attachment.html>


More information about the Plasma-devel mailing list