[Differential] [Request, 8 lines] D4705: Don't assume initialized if there are pending dbus replies

[Elvis Angelaccio]

elvisangelaccio created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  ConnectionEditorBase::initialize() does not count the number of pending dbus
  replies, so it is currently assuming that if control reaches the end of the
  function, we are not waiting for secrets and we can claim the kcm is
  initialized. That is not necessarily true, as bug #376739 shows.
  
  If we count the number of replies actually received, we can be sure that there
  are no more pending replies and we can then set m_initialized to true at the
  end of initialize().
  
  BUG: 376739
  FIXED-IN: 5.9.3

TEST PLAN
  Open Connection KCM from systemsettings5, no longer had the Apply button
  enabled. Playing with the KCM still enables the Apply button if something is
  changed.

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  Plasma/5.9

REVISION DETAIL
  https://phabricator.kde.org/D4705

AFFECTED FILES
  libs/editor/connectioneditorbase.cpp
  libs/editor/connectioneditorbase.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: elvisangelaccio, jgrulich
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170221/53155a39/attachment.html>