[Differential] [Commented On] D4667: [applet] Let specify a version for applets private plugins

[Harald Sitter]

sitter added a comment.


  You could just build an autotest maybe? 👅
  
  So, let's try with the previously mentioned https://cgit.kde.org/plasma-desktop.git/commit/?h=Plasma/5.9&id=dc17f78ebcc76600040a8d2ef8c57b9a41a8d06e
  
  I am doing:
  
    git clone --branch Plasma/5.9 kde:plasma-desktop
    git revert dc17f78ebcc76600040a8d2ef8c57b9a41a8d06e
    cmake && make && make install
    kquitapp plasmashell
    git revert HEAD # revert the revert to apply the change again
    make && make install
  
  I do not observe a crash with this. Nor would I expect one because, as davidedmundson pointed out, the new plugin library would not get loaded until plasmashell is restarted. Maybe I am testing incorrectly though.
  
  But to verify the file loading let's check the process map. This is loaded at first:
  
    $ pmap -X -p `pidof plasmashell` | grep private/taskmanager/libtaskmanagerplugin
        7f1723dd8000 r-xp  00000000  00:15 10808567     152    152    152        152         0              0              0               0    0       0      0 /usr/lib/x86_64-linux-gnu/qt5/qml/org/kde/plasma/private/taskmanager/libtaskmanagerplugin.so
        7f1723dfe000 ---p  00026000  00:15 10808567    2048      0      0          0         0              0              0               0    0       0      0 /usr/lib/x86_64-linux-gnu/qt5/qml/org/kde/plasma/private/taskmanager/libtaskmanagerplugin.so
        7f1723ffe000 r--p  00026000  00:15 10808567       4      4      4          4         4              0              0               0    0       0      0 /usr/lib/x86_64-linux-gnu/qt5/qml/org/kde/plasma/private/taskmanager/libtaskmanagerplugin.so
        7f1723fff000 rw-p  00027000  00:15 10808567       4      4      4          4         4              0              0               0    0       0      0 /usr/lib/x86_64-linux-gnu/qt5/qml/org/kde/plasma/private/taskmanager/libtaskmanagerplugin.so
  
  Notably, the file is inode `10808567`. So, I bring back the change and install again:
  
    $ pmap -X -p `pidof plasmashell` | grep private/taskmanager/libtaskmanagerplugin
        7f1723dd8000 r-xp  00000000  00:15 10808567     152    152    152        152         0              0              0               0    0       0      0 /usr/lib/x86_64-linux-gnu/qt5/qml/org/kde/plasma/private/taskmanager/libtaskmanagerplugin.so (deleted)
        7f1723dfe000 ---p  00026000  00:15 10808567    2048      0      0          0         0              0              0               0    0       0      0 /usr/lib/x86_64-linux-gnu/qt5/qml/org/kde/plasma/private/taskmanager/libtaskmanagerplugin.so (deleted)
        7f1723ffe000 r--p  00026000  00:15 10808567       4      4      4          4         4              0              0               0    0       0      0 /usr/lib/x86_64-linux-gnu/qt5/qml/org/kde/plasma/private/taskmanager/libtaskmanagerplugin.so (deleted)
        7f1723fff000 rw-p  00027000  00:15 10808567       4      4      4          4         4              0              0               0    0       0      0 /usr/lib/x86_64-linux-gnu/qt5/qml/org/kde/plasma/private/taskmanager/libtaskmanagerplugin.so (deleted)
  
  As indicated by pmap we still have the same library loaded and as indicated the backing file is now deleted from disk.
  
  Checking the newly installed file we'll also see it having a different inode.
  
    $ ls -li /usr/lib/x86_64-linux-gnu/qt5/qml/org/kde/plasma/private/taskmanager/libtaskmanagerplugin.so
    10808655 -rw-r--r-- 1 root root 2259408 Feb 20 09:30 /usr/lib/x86_64-linux-gnu/qt5/qml/org/kde/plasma/private/taskmanager/libtaskmanagerplugin.so
  
  So, clearly the new library was not loaded, and I honestly fail to imagine a scenario where it would get loaded even though we have the file loaded already.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4667

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: anthonyfieroni, #plasma, davidedmundson, dfaure, sitter
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170220/4ef08445/attachment.html>