<table><tr><td style="">sitter added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D4667" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>You could just build an autotest maybe? 👅</p>
<p>So, let's try with the previously mentioned <a href="https://cgit.kde.org/plasma-desktop.git/commit/?h=Plasma/5.9&id=dc17f78ebcc76600040a8d2ef8c57b9a41a8d06e" class="remarkup-link" target="_blank" rel="noreferrer">https://cgit.kde.org/plasma-desktop.git/commit/?h=Plasma/5.9&id=dc17f78ebcc76600040a8d2ef8c57b9a41a8d06e</a></p>
<p>I am doing:</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">git clone --branch Plasma/5.9 kde:plasma-desktop
git revert dc17f78ebcc76600040a8d2ef8c57b9a41a8d06e
cmake && make && make install
kquitapp plasmashell
git revert HEAD # revert the revert to apply the change again
make && make install</pre></div>
<p>I do not observe a crash with this. Nor would I expect one because, as davidedmundson pointed out, the new plugin library would not get loaded until plasmashell is restarted. Maybe I am testing incorrectly though.</p>
<p>But to verify the file loading let's check the process map. This is loaded at first:</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="console" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);"><span style="color: #000080">$ pmap -X -p `pidof plasmashell` | grep private/taskmanager/libtaskmanagerplugin</span>
<span style="color: #808080"> 7f1723dd8000 r-xp 00000000 00:15 10808567 152 152 152 152 0 0 0 0 0 0 0 /usr/lib/x86_64-linux-gnu/qt5/qml/org/kde/plasma/private/taskmanager/libtaskmanagerplugin.so</span>
<span style="color: #808080"> 7f1723dfe000 ---p 00026000 00:15 10808567 2048 0 0 0 0 0 0 0 0 0 0 /usr/lib/x86_64-linux-gnu/qt5/qml/org/kde/plasma/private/taskmanager/libtaskmanagerplugin.so</span>
<span style="color: #808080"> 7f1723ffe000 r--p 00026000 00:15 10808567 4 4 4 4 4 0 0 0 0 0 0 /usr/lib/x86_64-linux-gnu/qt5/qml/org/kde/plasma/private/taskmanager/libtaskmanagerplugin.so</span>
<span style="color: #808080"> 7f1723fff000 rw-p 00027000 00:15 10808567 4 4 4 4 4 0 0 0 0 0 0 /usr/lib/x86_64-linux-gnu/qt5/qml/org/kde/plasma/private/taskmanager/libtaskmanagerplugin.so</span></pre></div>
<p>Notably, the file is inode <tt style="background: #ebebeb; font-size: 13px;">10808567</tt>. So, I bring back the change and install again:</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="console" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);"><span style="color: #000080">$ pmap -X -p `pidof plasmashell` | grep private/taskmanager/libtaskmanagerplugin</span>
<span style="color: #808080"> 7f1723dd8000 r-xp 00000000 00:15 10808567 152 152 152 152 0 0 0 0 0 0 0 /usr/lib/x86_64-linux-gnu/qt5/qml/org/kde/plasma/private/taskmanager/libtaskmanagerplugin.so (deleted)</span>
<span style="color: #808080"> 7f1723dfe000 ---p 00026000 00:15 10808567 2048 0 0 0 0 0 0 0 0 0 0 /usr/lib/x86_64-linux-gnu/qt5/qml/org/kde/plasma/private/taskmanager/libtaskmanagerplugin.so (deleted)</span>
<span style="color: #808080"> 7f1723ffe000 r--p 00026000 00:15 10808567 4 4 4 4 4 0 0 0 0 0 0 /usr/lib/x86_64-linux-gnu/qt5/qml/org/kde/plasma/private/taskmanager/libtaskmanagerplugin.so (deleted)</span>
<span style="color: #808080"> 7f1723fff000 rw-p 00027000 00:15 10808567 4 4 4 4 4 0 0 0 0 0 0 /usr/lib/x86_64-linux-gnu/qt5/qml/org/kde/plasma/private/taskmanager/libtaskmanagerplugin.so (deleted)</span></pre></div>
<p>As indicated by pmap we still have the same library loaded and as indicated the backing file is now deleted from disk.</p>
<p>Checking the newly installed file we'll also see it having a different inode.</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="console" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);"><span style="color: #000080">$ ls -li /usr/lib/x86_64-linux-gnu/qt5/qml/org/kde/plasma/private/taskmanager/libtaskmanagerplugin.so</span>
<span style="color: #808080">10808655 -rw-r--r-- 1 root root 2259408 Feb 20 09:30 /usr/lib/x86_64-linux-gnu/qt5/qml/org/kde/plasma/private/taskmanager/libtaskmanagerplugin.so</span></pre></div>
<p>So, clearly the new library was not loaded, and I honestly fail to imagine a scenario where it would get loaded even though we have the file loaded already.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D4667" rel="noreferrer">https://phabricator.kde.org/D4667</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>anthonyfieroni, Plasma, davidedmundson, dfaure, sitter<br /><strong>Cc: </strong>plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol<br /></div>