D8232: Add option to center shadow
Andres Betts
noreply at phabricator.kde.org
Sun Dec 31 20:13:30 UTC 2017
abetts added a comment.
In https://phabricator.kde.org/D8232#184486, @hpereiradacosta wrote:
> In https://phabricator.kde.org/D8232#184470, @abetts wrote:
>
> > In https://phabricator.kde.org/D8232#183783, @ngraham wrote:
> >
> > > Per recent https://phabricator.kde.org/tag/vdg/ discussions, I've put together a patch that changes the defaults to horizontally center window and menu shadows, and make them a bit larger: https://phabricator.kde.org/D9549
> >
> >
> > Agreed! I think also, we can always experiment and change things going forward. I don't think of this patch as the ultimate solution. Just another iteration in an evolving theme.
>
>
> I would really like to avoid too many iterations on this topic. Window decoration are very visible to users, so changing it every two releases gives a really bad impression.
> We _should_ get it as right as possible before pushing to the official repo, sorry.
> Andy, if you think the shadow should be improved, please indicate how so that the patch gets fixed before its get committed.
> Devs can work with patches, there is no need to commit.
I mean to say that the shadows are improved with this patch being proposed. I would not change anything. My thought is that in future years we can revisit and think if we need to make any changes.
REPOSITORY
R31 Breeze
REVISION DETAIL
https://phabricator.kde.org/D8232
To: rpelorosso, #breeze, #vdg, hpereiradacosta
Cc: emateli, sebas, januz, alex-l, alake, abetts, progwolff, mvourlakos, rkflx, ngraham, davidedmundson, mart, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171231/979306ba/attachment.html>
More information about the Plasma-devel
mailing list