D9549: Horizontally center shadows and make them bigger
Hugo Pereira Da Costa
noreply at phabricator.kde.org
Sun Dec 31 12:27:13 UTC 2017
hpereiradacosta added a comment.
In https://phabricator.kde.org/D9549#184323, @hpereiradacosta wrote:
> I have no objection to the change, in principle.
> Now:
>
> - I feel that the top shadow at least should be somewhat smaller than the three other sides. Comments welcome
Ok looking at the code it seems the top shadow is already smaller.
In which case please ignore :)
I guess I should give a try to actually apply the provided patch ... Will do and keep you posted.
> - could you check with ALake. He is also VDG and the original style/decoration designer. If he already gives his approval on any other channel (e.g. Telegram), then fine with me too.
> - there is another review (I think, don't remember which), on the same topic, and which should be discarded if this one gets landed.
> - Did you check that there is no *glitch* with the shadow maximum size, on small size tooltips' shadow. (last time I checked there was one, which I had no time to fix).
REPOSITORY
R31 Breeze
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9549
To: ngraham, abetts, hpereiradacosta, #vdg, #breeze
Cc: januz, rpelorosso, apol, mvourlakos, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171231/f0ddc6af/attachment.html>
More information about the Plasma-devel
mailing list