D9312: [ConfigPropertyMap] Don't emit valueChanged on initial creation

Kai Uwe Broulik noreply at phabricator.kde.org
Wed Dec 13 13:31:49 UTC 2017


broulik created this revision.
broulik added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  We initially populate the `QQmlPropertyMap` with all keys in settings after which the properties are created for the first time. There's no need to emit value changed then.

TEST PLAN
  Plasma starts normal, applet configs are loaded and persisted.
  I didn't actually find a case where `KCoreConfigSkeleton::configChanged` would be called as in `writeConfigValue` we block signals and we don't monitor outside config changes. Probably still needs more testing.
  
  Saves 60ms plasmashell startup

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D9312

AFFECTED FILES
  src/kdeclarative/configpropertymap.cpp
  src/kdeclarative/configpropertymap.h

To: broulik, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171213/e3e016bf/attachment-0001.html>


More information about the Plasma-devel mailing list