<table><tr><td style="">broulik created this revision.<br />broulik added a reviewer: Plasma.<br />Restricted Application added projects: Plasma, Frameworks.<br />Restricted Application added subscribers: Frameworks, plasma-devel.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D9312" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>We initially populate the <tt style="background: #ebebeb; font-size: 13px;">QQmlPropertyMap</tt> with all keys in settings after which the properties are created for the first time. There's no need to emit value changed then.</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>Plasma starts normal, applet configs are loaded and persisted.<br />
I didn't actually find a case where <tt style="background: #ebebeb; font-size: 13px;">KCoreConfigSkeleton::configChanged</tt> would be called as in <tt style="background: #ebebeb; font-size: 13px;">writeConfigValue</tt> we block signals and we don't monitor outside config changes. Probably still needs more testing.</p>
<p>Saves 60ms plasmashell startup</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R296 KDeclarative</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D9312" rel="noreferrer">https://phabricator.kde.org/D9312</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>src/kdeclarative/configpropertymap.cpp<br />
src/kdeclarative/configpropertymap.h</div></div></div><br /><div><strong>To: </strong>broulik, Plasma<br /><strong>Cc: </strong>plasma-devel, Frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>