D9255: [Notifications] Add visible menu button to thumbnail strip

[Kai Uwe Broulik]

broulik added a comment.


  > Or should we remove the "Öffnen/Open" button?
  
  Good idea. However, the "Open" button is created by the application itself and there's no way of knowing to the application whether the notification server supports that thumbnail strip that is proprietary to Plasma and non-standard. While FDO specifies a "Capabilities" property that a client can query to see what it supports, that isn't accessible through `KNotifications`. In short: if we remove the "Open" button on other desktops the user won't get any way of accessing the screenshot.

INLINE COMMENTS

> romangg wrote in ThumbnailStrip.qml:113
> Since now the thumbnail is clickable, remove.
> 
> Also could you give the thumbnail an effect to show that it is clickable? Best would be imo a frame in highlight color, which switches to the context menu button, when mouse cursor moves from thumbnail to inside of context menu button area. This would be consistent with other elements of the workspace (with breeze).
> 
> But since we have not yet decided on a consistent highlighting scheme in general, you can also try other styles.

The thumbnail has *always* been clickable.

The open hand cursor is merely an indicator to show that it's draggable, the very reason this feature exists.

> romangg wrote in thumbnailer.cpp:189
> The following code positions the menu according to the button. But it still covers half of it. The context menu should not cover the button at all. Can you somehow use PlasmaComponents.Menu? It already has suitable placement code covering special cases (not enough space etc.).
> 
> Otherwise copy the placement code from its C++ part and use it here.

The problem is not the placing but the fact that the actions are populated asynchronously, you can observe the same in Dolphin where the context menu sometimes (very rarely, actually) shows up detached from the cursor position.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D9255

To: broulik, #plasma, #vdg, ngraham, romangg
Cc: januz, romangg, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171209/068a5438/attachment.html>