D9271: Fixed memory leak in new_argv
Anthony Fieroni
noreply at phabricator.kde.org
Sat Dec 9 18:26:20 UTC 2017
anthonyfieroni added inline comments.
INLINE COMMENTS
> main.cpp:1092-1093
>
> int new_argc = 0;
> - char **new_argv = new char * [40];
> + char **new_argv = new char * [40]; //Memory Leak
>
Remove all references to them, they are unused.
> Viewer.cpp:146
> viewer->showUrl(url);
> + delete viewer;
> first = false;
Wrong indentation.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D9271
To: nathanhenry
Cc: anthonyfieroni, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171209/99bbce91/attachment-0001.html>
More information about the Plasma-devel
mailing list