D9271: Fixed memory leak in new_argv
David Edmundson
noreply at phabricator.kde.org
Sat Dec 9 17:24:24 UTC 2017
davidedmundson added inline comments.
INLINE COMMENTS
> Viewer.cpp:140-143
> if (!first) {
> viewer=new KFI::CViewer;
> viewer->show();
> + delete viewer;
that can't be right.
> kcm.cpp:83-85
> Plasma::RunnerManager *manager = new Plasma::RunnerManager(this);
> manager->reloadConfiguration();
> + delete manager;
1. this doesn't leak
2. what's the point of making a manager?
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D9271
To: nathanhenry
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171209/f9139276/attachment.html>
More information about the Plasma-devel
mailing list