D9240: [RunnerManager] Use QThread::idealThreadCount() instead of going through Solid

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> runnermanager.cpp:105
>          if (numThreads > Queue::instance()->maximumNumberOfThreads()) {
>              Queue::instance()->setMaximumNumberOfThreads(numThreads);
>          }

Threadweaver defaults to
 inventoryMax(qMax(4, 2 * QThread::idealThreadCount()))

At which point we basically have written:

if( X > 2X )

which is never going to happen.

Frankly I'd say let threadweaver do its own thing and not try meddling with it.

REPOSITORY
  R308 KRunner

REVISION DETAIL
  https://phabricator.kde.org/D9240

To: broulik, #plasma, #frameworks
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171207/47eba029/attachment.html>