D8798: Add xf86-input-libinput support for X11 mouse backend.

[Xuetian Weng]

xuetianweng added a comment.


  In https://phabricator.kde.org/D8798#175698, @subdiff wrote:
  
  > Sorry for the long delay on a review.
  >
  > Can you give a short overview on how the switching works between Xlib and libinput backend on X? So what's the runtime detection if libinput is available or not? Somebody above said mouse kcm is not available without libinput anymore with this patch. But this should not happen of course.
  >
  > Naming the config option Pointer Acceleration is problematic, because libinput names another property "pointer acceleration". I think we should not change the  name. Unneeded deviation from upstream. Maybe better add a tooltip with a description if people complain.
  >
  > In the touchpad kcm the backends for libinput and xlib are in different files (in the same backend/x11 subfolder). Is this possible here as well?
  
  
  Well, there's nothing changed for X11 and things only get better. X11 doesn't use libinput directly, it uses a xf86 input driver called xf86-input-libinput. This change enables the kcm to configure the mouse option using this driver. Otherwise, the old kcm does nothing when people use this driver (it means some configuration in kcm doesn't work for them).
  
  From the dependency point of view, it only introduce a build time dependency on xf86-input-libinput (by using some string macro in it), just like we already depend on xf86-input-evdev as build dependency. While it is possible to to hardcode those strings directly, I don't feel comfortable doing so because it introduces risk of breakage that we will not notice.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  mouse

REVISION DETAIL
  https://phabricator.kde.org/D8798

To: xuetianweng, ngraham, #plasma, jriddell
Cc: subdiff, jriddell, apol, rkflx, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171204/ff3b082a/attachment.html>