D7567: Support edit and appstream actions also for application search results

Eike Hein noreply at phabricator.kde.org
Mon Aug 28 19:27:04 UTC 2017


hein added inline comments.

INLINE COMMENTS

> mak wrote in actionlist.cpp:380
> This will not work, because the component-ID can be an arbitrary reverse-DNS string identifying the application, and doesn't have to resemble the .desktop-entry-id at all. If that happens, it's purely accidental.
> 
> I was planning to add a `componentsByLaunchable(TYPE, STR)` method to AppStream anyway, I could probably do that for the next release of AS.

That code wasn't touched during this refactoring, so this is immaterial to the review. Please inform Aleix Pol about it.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D7567

To: hein, #plasma, broulik, davidedmundson
Cc: mak, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170828/7ea58faa/attachment.html>


More information about the Plasma-devel mailing list