D7475: Make EffectsHandlerImpl::announceSupportProperty work without X11
Martin Flöser
noreply at phabricator.kde.org
Wed Aug 23 09:44:46 UTC 2017
graesslin created this revision.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REVISION SUMMARY
announceSupportProperty is called from the effects on startup. It
registers the property on the X11 root window. If we would start
kwin_wayland without XWayland support this would result in a crash.
This change refactors the code so that it still registers the property,
but does not try to interact with X11. Once X11 support is available it
does the actual registering.
But this means that the effects get an incorrect atom returned. This
needs additional changes. E.g. they could also react to the
x11ConnectionChanged and register again, then they would get the proper
atom. This would also support restart of XWayland.
REPOSITORY
R108 KWin
BRANCH
effects-announce-support-property-no-x11
REVISION DETAIL
https://phabricator.kde.org/D7475
AFFECTED FILES
effects.cpp
To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170823/ba8d08ef/attachment.html>
More information about the Plasma-devel
mailing list