D7267: Add support for moving group members within a group.

Eike Hein noreply at phabricator.kde.org
Mon Aug 14 07:11:05 UTC 2017


hein added inline comments.

INLINE COMMENTS

> davidedmundson wrote in tasksmodel.cpp:1553
> This is the only bit that's different from the new code.
> 
> Can we share the above and guard this with if(!parent)

I was uncomfortable just always passing parent through in beginMoveRows without guarding that with a check, too, but OK ...

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D7267

To: hein, #plasma, davidedmundson, argonel
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170814/29f108fc/attachment-0001.html>


More information about the Plasma-devel mailing list