D7267: Add support for moving group members within a group.

David Edmundson noreply at phabricator.kde.org
Sat Aug 12 07:16:34 UTC 2017


davidedmundson added inline comments.

INLINE COMMENTS

> tasksmodel.cpp:1553
> +
> +            // If we moved a group parent, consolidate sort map for children.
> +            if (groupMode() != GroupDisabled && d->groupingProxyModel->rowCount(groupingRowIndex)) {

This is the only bit that's different from the new code.

Can we share the above and guard this with if(!parent)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D7267

To: hein, #plasma, davidedmundson, argonel
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170812/d25888d0/attachment-0001.html>


More information about the Plasma-devel mailing list