D7046: Use xcb-icccm to read the name property

Christoph Feck noreply at phabricator.kde.org
Mon Aug 7 16:34:01 UTC 2017


cfeck added inline comments.

INLINE COMMENTS

> graesslin wrote in client.cpp:1428
> Just to add a little bit of context here: we are discussing two memcopies here in a code path which performs a roundtrip to the X server. This thing is going to be slow and the memcopy does not matter at all.
> 
> Yes the code is not perfect, but it also doesn't matter. If someone feels like changing the code, feel free.

Sure, I don't want to block your code. Just wanted to let you know that you are rejecting Fabian's proposals for emotional reasons, not for technical reasons.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D7046

To: graesslin, #kwin, #plasma
Cc: cfeck, anthonyfieroni, fvogt, broulik, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170807/dad069ec/attachment.html>


More information about the Plasma-devel mailing list