D7046: Use xcb-icccm to read the name property

[Martin Flöser]

graesslin added inline comments.

INLINE COMMENTS

> cfeck wrote in client.cpp:1428
> If Qt6 would introduce UTF-8 encoded QString (so that QString::fromUtf8() would no longer need to create a new array), then you can expect all Qt software to break. QString::fromUtf8() is used nearly everywhere.

Just to add a little bit of context here: we are discussing two memcopies here in a code path which performs a roundtrip to the X server. This thing is going to be slow and the memcopy does not matter at all.

Yes the code is not perfect, but it also doesn't matter. If someone feels like changing the code, feel free.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D7046

To: graesslin, #kwin, #plasma
Cc: cfeck, anthonyfieroni, fvogt, broulik, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170807/f1e9669b/attachment-0001.html>