D5381: Add brightness control using ddcutil lib
noreply at phabricator.kde.org
Thu Apr 13 19:58:44 UTC 2017
dvogel updated this revision to Diff 13395.
dvogel marked 6 inline comments as done.
dvogel added a comment.
Applied changes suggested by reviewers.
The only issue remaining is brightness restoration when waking up the monitor after shutting it down: we try to set brightness before the monitor is actually ready. Setting then fails, and the monitor wakes up with the last value it was dimmed to before shut down.
TODO: Make ddcutillib optional, for now not having ddcutil installed will most likely result in a crash.
CHANGES SINCE LAST UPDATE
To: dvogel, broulik
Cc: davidedmundson, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the Plasma-devel