D5381: Add brightness control using ddcutil lib

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> ddcutilbrightness.cpp:149
> +    
> +    ddca_get_vcp_value(m_displayHandleList.at(0),
> +                       m_descrToVcp_perDisp.at(0)->value("Brightness"),

you should check the return of this == 0

In case of error I would expect returnValue to not be set.

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D5381

To: dvogel, broulik
Cc: davidedmundson, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170411/448ae670/attachment.html>