D5423: Guard against Applet not loading AppletInterface

[David Edmundson]

davidedmundson created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  This can happen if an applet has invalid metadata, it doesn't have a
  script engine set (X-Plasma-API) so it won't load the DeclarativeAppletScripts
  Having invalid metadata could come from the applet, or from the fallback applet
  created in Containment::Private::createApplet.
  
  We guard against it in appletAdded but not in appletRemoved, which is
  inconsistent. We also apparently must have guards elsewhere otherwise
  we'd see the crash more.
  
  BUG: 377050

TEST PLAN
  Had corrupt applet, used to crash, now doesn't

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  origin-master (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D5423

AFFECTED FILES
  src/scriptengines/qml/plasmoid/containmentinterface.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170413/18c287e0/attachment.html>