<table><tr><td style="">davidedmundson created this revision.<br />Restricted Application added projects: Plasma, Frameworks.<br />Restricted Application added subscribers: Frameworks, plasma-devel.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D5423" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>This can happen if an applet has invalid metadata, it doesn't have a<br />
script engine set (X-Plasma-API) so it won't load the DeclarativeAppletScripts<br />
Having invalid metadata could come from the applet, or from the fallback applet<br />
created in Containment::Private::createApplet.</p>
<p>We guard against it in appletAdded but not in appletRemoved, which is<br />
inconsistent. We also apparently must have guards elsewhere otherwise<br />
we'd see the crash more.</p>
<p>BUG: 377050</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>Had corrupt applet, used to crash, now doesn't</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R242 Plasma Framework (Library)</div></div></div><br /><div><strong>BRANCH</strong><div><div>origin-master (branched from master)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D5423" rel="noreferrer">https://phabricator.kde.org/D5423</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>src/scriptengines/qml/plasmoid/containmentinterface.cpp</div></div></div><br /><div><strong>To: </strong>davidedmundson, Plasma<br /><strong>Cc: </strong>plasma-devel, Frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol<br /></div>