D5405: Create desktop file name based on organization domain unless set explicitely

[Luigi Toscano]

ltoscano added a comment.


  In https://phabricator.kde.org/D5405#101577, @kossebau wrote:
  
  > In https://phabricator.kde.org/D5405#101574, @ltoscano wrote:
  >
  > > I'm still confused. Documentation or not, bad usage or not, is it correct that desktop file name is constructed from both the organization domain AND the homepage?
  >
  >
  > In the current KAboutData code, it is constructed from the org domain only.  But the org domain itself is default constructed from the homepage url, if one is passed in that one constructor where possible (default to kde.org homepage). So if there is a relationship, it is indirectly.
  >  The other constructor simply defaults to kde.org/org.kde for both.
  
  
  But the point is not whether the organization domain is constructed from the homepage by default. The point is that, if both are explicitly set, the desktop files come from both, if I'm not misreading the code.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D5405

To: stikonas, mpyne, kossebau, aacid, ltoscano
Cc: mak, plasma-devel, kde-frameworks-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170412/862750f0/attachment.html>