D5345: Calendar: Use correct language for month and day names

Martin Klapetek noreply at phabricator.kde.org
Tue Apr 11 02:54:36 UTC 2017


mck182 accepted this revision.
mck182 added a comment.
This revision is now accepted and ready to land.


  ...provided the usage of `uiLanguages[0]` is safe like this.

INLINE COMMENTS

> DaysCalendar.qml:315
>                  height: daysCalendar.cellHeight
> -                text: Qt.locale().dayName(calendarBackend.firstDayOfWeek + index, Locale.ShortFormat)
> +                text: Qt.locale(Qt.locale().uiLanguages[0]).dayName(calendarBackend.firstDayOfWeek + index, Locale.ShortFormat)
>                  font.pixelSize: Math.max(theme.smallestFont.pixelSize, daysCalendar.cellHeight / 3)

Now I'm not entirely sure but can the `uiLanguages[0]`
possibly return null?

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5345

To: drosca, #plasma, mck182
Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170411/7e854428/attachment.html>


More information about the Plasma-devel mailing list