<table><tr><td style="">mck182 accepted this revision.<br />mck182 added a comment.<br />This revision is now accepted and ready to land.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D5345" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>...provided the usage of <tt style="background: #ebebeb; font-size: 13px;">uiLanguages[0]</tt> is safe like this.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D5345#inline-22107" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">DaysCalendar.qml:315</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">                <span style="color: #aa4000">height:</span> <span style="color: #004012">daysCalendar</span><span class="p">.</span><span style="color: #004012">cellHeight</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">                <span style="color: #aa4000">text:</span> <span style="color: #004012">Qt</span><span class="p">.</span><span style="color: #004012">locale</span><span class="p">().</span><span style="color: #004012">dayName</span><span class="p">(</span><span style="color: #004012">calendarBackend</span><span class="p">.</span><span style="color: #004012">firstDayOfWeek</span> <span style="color: #aa2211">+</span> <span style="color: #004012">index</span><span class="p">,</span> <span style="color: #004012">Locale</span><span class="p">.</span><span style="color: #004012">ShortFormat</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                <span style="color: #aa4000">text:</span> <span style="color: #004012">Qt</span><span class="p">.</span><span style="color: #004012">locale</span><span class="p">(<span class="bright"></span></span><span class="bright"></span><span style="color: #004012"><span class="bright">Qt</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">locale</span></span><span class="bright"></span><span class="p"><span class="bright">().</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">uiLanguages</span></span><span class="bright"></span><span class="p"><span class="bright">[</span></span><span class="bright"></span><span style="color: #601200"><span class="bright">0</span></span><span class="bright"></span><span class="p"><span class="bright">]</span>).</span><span style="color: #004012">dayName</span><span class="p">(</span><span style="color: #004012">calendarBackend</span><span class="p">.</span><span style="color: #004012">firstDayOfWeek</span> <span style="color: #aa2211">+</span> <span style="color: #004012">index</span><span class="p">,</span> <span style="color: #004012">Locale</span><span class="p">.</span><span style="color: #004012">ShortFormat</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">                <span style="color: #aa4000">font.pixelSize:</span> <span style="color: #304a96">Math</span><span class="p">.</span><span style="color: #004012">max</span><span class="p">(</span><span style="color: #004012">theme</span><span class="p">.</span><span style="color: #004012">smallestFont</span><span class="p">.</span><span style="color: #004012">pixelSize</span><span class="p">,</span> <span style="color: #004012">daysCalendar</span><span class="p">.</span><span style="color: #004012">cellHeight</span> <span style="color: #aa2211">/</span> <span style="color: #601200">3</span><span class="p">)</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Now I'm not entirely sure but can the <tt style="background: #ebebeb; font-size: 13px;">uiLanguages[0]</tt><br />
possibly return null?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R242 Plasma Framework (Library)</div></div></div><br /><div><strong>BRANCH</strong><div><div>master</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D5345" rel="noreferrer">https://phabricator.kde.org/D5345</a></div></div><br /><div><strong>To: </strong>drosca, Plasma, mck182<br /><strong>Cc: </strong>plasma-devel, Frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol<br /></div>