D5158: Support the emergency show property on ksld's lock screen window

Martin Gräßlin noreply at phabricator.kde.org
Thu Apr 6 05:10:47 UTC 2017


graesslin added inline comments.

INLINE COMMENTS

> broulik wrote in shell_client.cpp:989
> Should this not fall-through rather than always returning if m_internalWindow?

if m_internalWindow is true the next condition can never be true. Due to that I use a direct return.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D5158

To: graesslin, #kwin, #plasma
Cc: broulik, plasma-devel, kwin, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170406/bd995a76/attachment.html>


More information about the Plasma-devel mailing list