D5158: Support the emergency show property on ksld's lock screen window

Kai Uwe Broulik noreply at phabricator.kde.org
Wed Apr 5 20:12:14 UTC 2017


broulik added inline comments.

INLINE COMMENTS

> shell_client.cpp:989
> +    if (m_internalWindow) {
> +        return m_internalWindow->property("org_kde_ksld_emergency").toBool();
> +    }

Should this not fall-through rather than always returning if m_internalWindow?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D5158

To: graesslin, #kwin, #plasma
Cc: broulik, plasma-devel, kwin, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170405/c461d77f/attachment-0001.html>


More information about the Plasma-devel mailing list