D5144: Change the volume icon/mute button into a ToolButton

David Rosca noreply at phabricator.kde.org
Sun Apr 2 15:00:19 UTC 2017


drosca added a comment.


  
  
  In https://phabricator.kde.org/D5144#97171, @Zren wrote:
  
  > Before tackling the implicitWidth/height stuff, I noticed that my microphone's Heading label was getting moved on the first click. Adding `height: contextMenuButton.height` fixes it but that doesn't feel right.
  >
  > https://streamable.com/07hc0
  
  
  I've seen that, but that is unrelated to this change, so please move it into separate review.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D5144

To: Zren, #plasma, subdiff, drosca
Cc: mart, subdiff, drosca, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170402/3adf8ddb/attachment.html>


More information about the Plasma-devel mailing list