[Differential] [Changed Subscribers] D2894: Start KDE Cleanups

[broulik (Kai Uwe Broulik)]

broulik added inline comments.

INLINE COMMENTS

> startkde.cmake:6
>  
> -if test "x$1" = x--failsafe; then
> -    KDE_FAILSAFE=1 # General failsafe flag

Don't we install an "kde failsafe" x session which uses that?

> startkde.cmake:153
>  
> -# TODO: Use GenericConfigLocation once we depend on Qt 5.4
> -scriptpath=`qtpaths --paths ConfigLocation | tr ':' '\n' | sed 's,$,/plasma-workspace,g'`
> +scriptpath=`qtpaths --paths GenericConfigLocation | tr ':' '\n' | sed 's,$,/plasma-workspace,g'`
>  

Is that see still needed/correct with generic config location?

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2894

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160930/8585eaa8/attachment-0001.html>