Review Request 129033: plural description

Marco Martin notmart at gmail.com
Tue Sep 27 11:00:55 UTC 2016



> On Sept. 27, 2016, 10:50 a.m., Marco Martin wrote:
> > as we are in string freeze, Is this in master only right?
> 
> Andreas Kainz wrote:
>     I only push in master branches. I hope this is correct but if I have something for backporting, I would ask someone of the plasma team. In LibreOffice I learn that you can push into master when someone make a review. if you want to backport stuff you need two reviewers. I think this is a good strategy.
>     
>     I push to master and it isn't my intention to push to 5.8.

ok then, for master the change is all good :)

here my question was because being near to release, if a string needs to be changed, a special exception needs to be granted by the translators, as they should be aware (because changing a message near release means said message won't be translated anymore)


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129033/#review99572
-----------------------------------------------------------


On Sept. 26, 2016, 8:45 p.m., Andreas Kainz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129033/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2016, 8:45 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: systemsettings
> 
> 
> Description
> -------
> 
> the single kcm's use the plural description so also the group should use plural like Icons.
> 
> 
> Diffs
> -----
> 
>   categories/settings-appearance-color.desktop 973ad8b 
>   categories/settings-appearance-font.desktop 53f0993 
> 
> Diff: https://git.reviewboard.kde.org/r/129033/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andreas Kainz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160927/6e52e746/attachment.html>


More information about the Plasma-devel mailing list